Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_0_X] Add ParticleFlow Client for Online DQM - GPUvsCPU comparison #45204

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

waredjeb
Copy link
Contributor

This is a backport of #45079.

This PR creates a new Online DQM client for Particle Flow, taking inspiration from the HCAL GPU client. Currently, the PF client will be used to monitor PFCluster@Alpaka and compare the GPU with the CPU version from the DQMGPUvsCPU stream.

Test

Local test on lxplus with the following command, following instructions on the DQM Twiki
cmsRun DQM/Integration/python/clients/pfpu_dqm_sourceclient-live_cfg.py runInputDir=/eos/cms/store/group/comm_dqm/ runNumber=380649 runkey=pp_run scanOnce=True

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 12, 2024

A new Pull Request was created by @waredjeb for CMSSW_14_0_X.

It involves the following packages:

  • DQM/Integration (dqm)
  • DQM/PFTasks (dqm)

@tjavaid, @cmsbuild, @rvenditti, @antoniovagnerini, @syuvivida, @nothingface0 can you please review it and eventually sign? Thanks.
@threus, @batinkov, @francescobrivio this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 12, 2024

cms-bot internal usage

@tjavaid
Copy link

tjavaid commented Jun 12, 2024

backport of #45079

@tjavaid
Copy link

tjavaid commented Jun 12, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-684ae6/39848/summary.html
COMMIT: 2ab99a4
CMSSW: CMSSW_14_0_X_2024-06-11-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45204/39848/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@syuvivida
Copy link
Contributor

Hello @waredjeb
Would you like this PR to be deployed for the coming data on Sunday? We tested this PR with 14_0_8 and run 381286 and you could inspect plots at the playback DQMGUI here. However, we are expected to run with 14_0_9, and with new streamer format, we could only test with the streamers of run 381549 (which didn't have HCAL included). Not sure if it is because of this, all the 2D plots in the 'ParticleFlow/ pfCaloGPUCompDir' are empty when testing with 14_0_9 and run 381549 test streamers were empty

@waredjeb
Copy link
Contributor Author

waredjeb commented Jun 12, 2024

Hello @waredjeb Would you like this PR to be deployed for the coming data on Sunday? We tested this PR with 14_0_8 and run 381286 and you could inspect plots at the playback DQMGUI here. However, we are expected to run with 14_0_9, and with new streamer format, we could only test with the streamers of run 381549 (which didn't have HCAL included). Not sure if it is because of this, all the 2D plots in the 'ParticleFlow/ pfCaloGPUCompDir' are empty when testing with 14_0_9 and run 381549 test streamers were empty

Yes. we would like to deploy this PR in the coming data on Sunday! Thank you!
Regarding run 381549 test streamers, if HCAL was not available, empty plots are okay. The PFCluster collection in consideration comes from HCAL only.

@tjavaid
Copy link

tjavaid commented Jun 13, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@swagata87
Copy link
Contributor

type pf

@cmsbuild cmsbuild added the pf label Jun 13, 2024
@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d57d963 into cms-sw:CMSSW_14_0_X Jun 13, 2024
10 checks passed
@syuvivida
Copy link
Contributor

Hello @waredjeb
This pfgpu client has just been deployed in online DQM (together with 14_0_9), starting from run 381944.

@waredjeb
Copy link
Contributor Author

Hello @waredjeb This pfgpu client has just been deployed in online DQM (together with 14_0_9), starting from run 381944.

Hi @syuvivida Thank you very much!

@syuvivida
Copy link
Contributor

BTW, the DQM shifter is asking they shall monitor the plots. When the PF group is ready to include shift instruction, please let us know. Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants